Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site classification locale files to distinclude #671

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

IMPORTANT: To be merged only after newfold-labs/wp-module-data#29 has been merged and a release has been tagged for the same.

@arunshenoy99
Copy link
Member Author

IMPORTANT: To be merged only after newfold-labs/wp-module-data#29 has been merged and a release has been tagged for the same.

@circlecube circlecube changed the base branch from main to develop September 18, 2023 19:08
* develop:
  changes
  add new runtime filter and update webpack value
  bump runtime module to 1.0.4
  bump data module to 2.4.4
  Payments not showing in navigation
  various minor updates for packages and modules
  version bump
  also update home tests with new classnames
  set the update coming-soon module version explicitly in composer
  update ecommerce module to latest so coming soon test passes (a class name was changed)
  Update onboarding version
  Enable 'Yoast AI' by default
  update to released version of performance module 1.2.0
  GitHub Actions(deps): Bump actions/checkout from 3 to 4
  remove customerData support
  remove all the existing onboarding steps
  update performance module to beta 2 to fix tests
  use performance module components and tests
  load `Data.php` via `include_once` in `add_to_runtinme`
  Removing the onboarding cypress tests

# Conflicts:
#	composer.json
#	composer.lock
@circlecube circlecube merged commit 675f2ce into develop Sep 18, 2023
@circlecube circlecube deleted the add/site-classification-locale branch September 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants